Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1796] Fixed accessibility issue with collapsible area in endpoint dialog. #1842

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Sep 5, 2019

#1796

===

The collapsible region was not reading expanded / collapsed state when using a screen reader, now it reads the state properly:

"Azure bot service configuration button (expanded | collapsed)"

I also fixed the markup and styling.

Before:

image

After:

image

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 5, 2019

Coverage Status

Coverage increased (+0.002%) to 65.767% when pulling b067a56 on toanzian/acc-#1796 into 4e3fab1 on master.

Copy link
Member

corinagum left a comment

👍

@tonyanziano tonyanziano force-pushed the toanzian/acc-#1796 branch from d5ba5c1 to b067a56 Sep 6, 2019
@tonyanziano tonyanziano merged commit 54aa2cc into master Sep 6, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #78110 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/acc-#1796 branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.