Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[#1796] Fixed accessibility issue with collapsible area in endpoint dialog.#1842

Merged
tonyanziano merged 1 commit into
masterfrom
toanzian/acc-#1796
Sep 6, 2019
Merged

[#1796] Fixed accessibility issue with collapsible area in endpoint dialog.#1842
tonyanziano merged 1 commit into
masterfrom
toanzian/acc-#1796

Conversation

@tonyanziano
Copy link
Copy Markdown
Contributor

#1796

===

The collapsible region was not reading expanded / collapsed state when using a screen reader, now it reads the state properly:

"Azure bot service configuration button (expanded | collapsed)"

I also fixed the markup and styling.

Before:

image

After:

image

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 5, 2019

Coverage Status

Coverage increased (+0.002%) to 65.767% when pulling b067a56 on toanzian/acc-#1796 into 4e3fab1 on master.

corinagum
corinagum previously approved these changes Sep 6, 2019
Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tonyanziano tonyanziano merged commit 54aa2cc into master Sep 6, 2019
@tonyanziano tonyanziano deleted the toanzian/acc-#1796 branch September 6, 2019 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants