Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1802, #1803, #1804, #1876] Added HTML App Menu for Windows #1893

Merged
merged 2 commits into from Oct 8, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Oct 2, 2019

#1876, #1802, #1803, #1804

===

image

image

image

@tonyanziano tonyanziano changed the title Added HTML App Menu for Windows [#1802, #1803, #1804, #1876] Added HTML App Menu for Windows Oct 2, 2019
@tonyanziano tonyanziano force-pushed the toanzian/app-menu-show-via-props branch from e7a2b6a to 89920ed Oct 4, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 4, 2019

Coverage Status

Coverage increased (+0.9%) to 66.84% when pulling 71537b2 on toanzian/app-menu-show-via-props into c53ac1d on master.

@tonyanziano tonyanziano force-pushed the toanzian/app-menu-show-via-props branch from 89920ed to e3dd231 Oct 4, 2019
@tonyanziano tonyanziano marked this pull request as ready for review Oct 4, 2019
@tonyanziano tonyanziano force-pushed the toanzian/app-menu-show-via-props branch 2 times, most recently from 8f07c4d to f0b1be2 Oct 4, 2019
Copy link
Member

corinagum left a comment

looks awesome! I just left teeny comments.

I also tested this out with NVDA and everything seems to work awesome!

The only comment I have is that when using browse mode in the app menu, for example highlighting "Zoom in" under View, pressing escape, then Ctrl + LeftArrow to highlight Conversation will say "Out of menu button menu button sub menu Conversation". I'm assuming this is because it's trying to highlight within the sub menu, rather than the top level, but that panel is disabled. I'm also not sure if this is something the a11y team would highlight as need to fix, but I thought I would mention it just in case.

@tonyanziano tonyanziano force-pushed the toanzian/app-menu-show-via-props branch from f0b1be2 to ef4b405 Oct 7, 2019
@tonyanziano

This comment has been minimized.

Copy link
Contributor Author

tonyanziano commented Oct 7, 2019

@corinagum Addressed your comments.

Thanks for the note on the menu accessibility, I didn't even know you could use Ctrl+<arrow> to navigate lists, so I didn't test any of that.

My thought is that we submit it as is, and then if the a11y team ends up dinging us for that, we can fix it. However, to my memory, I don't think they reported any issues involving Ctrl+<arrow> navigation, but maybe we just didn't have any instances like the app menu.

@corinagum corinagum merged commit 19a9b3b into master Oct 8, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #82031 succeeded
Details
license/cla All CLA requirements met.
Details
@corinagum corinagum deleted the toanzian/app-menu-show-via-props branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.