Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[#1802, #1803, #1804, #1876] Added HTML App Menu for Windows#1893

Merged
corinagum merged 2 commits into
masterfrom
toanzian/app-menu-show-via-props
Oct 8, 2019
Merged

[#1802, #1803, #1804, #1876] Added HTML App Menu for Windows#1893
corinagum merged 2 commits into
masterfrom
toanzian/app-menu-show-via-props

Conversation

@tonyanziano
Copy link
Copy Markdown
Contributor

@tonyanziano tonyanziano commented Oct 2, 2019

@tonyanziano tonyanziano changed the title Added HTML App Menu for Windows [#1802, #1803, #1804, #1876] Added HTML App Menu for Windows Oct 2, 2019
@tonyanziano tonyanziano force-pushed the toanzian/app-menu-show-via-props branch from e7a2b6a to 89920ed Compare October 4, 2019 18:20
@coveralls
Copy link
Copy Markdown

coveralls commented Oct 4, 2019

Coverage Status

Coverage increased (+0.9%) to 66.84% when pulling 71537b2 on toanzian/app-menu-show-via-props into c53ac1d on master.

@tonyanziano tonyanziano force-pushed the toanzian/app-menu-show-via-props branch from 89920ed to e3dd231 Compare October 4, 2019 19:08
@tonyanziano tonyanziano marked this pull request as ready for review October 4, 2019 19:11
@tonyanziano tonyanziano force-pushed the toanzian/app-menu-show-via-props branch 2 times, most recently from 8f07c4d to f0b1be2 Compare October 4, 2019 20:13
Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome! I just left teeny comments.

I also tested this out with NVDA and everything seems to work awesome!

The only comment I have is that when using browse mode in the app menu, for example highlighting "Zoom in" under View, pressing escape, then Ctrl + LeftArrow to highlight Conversation will say "Out of menu button menu button sub menu Conversation". I'm assuming this is because it's trying to highlight within the sub menu, rather than the top level, but that panel is disabled. I'm also not sure if this is something the a11y team would highlight as need to fix, but I thought I would mention it just in case.

Comment thread packages/sdk/ui-react/src/widget/menu/menu.scss Outdated
Comment thread packages/app/client/src/ui/shell/appMenu/appMenuTemplate.ts
Comment thread packages/sdk/ui-react/src/widget/menu/menuButton.tsx Outdated
@tonyanziano tonyanziano force-pushed the toanzian/app-menu-show-via-props branch from f0b1be2 to ef4b405 Compare October 7, 2019 23:28
@tonyanziano
Copy link
Copy Markdown
Contributor Author

@corinagum Addressed your comments.

Thanks for the note on the menu accessibility, I didn't even know you could use Ctrl+<arrow> to navigate lists, so I didn't test any of that.

My thought is that we submit it as is, and then if the a11y team ends up dinging us for that, we can fix it. However, to my memory, I don't think they reported any issues involving Ctrl+<arrow> navigation, but maybe we just didn't have any instances like the app menu.

corinagum
corinagum previously approved these changes Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants