Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1771] DefaultButton a11y styling fixes #1927

Merged
merged 2 commits into from Oct 15, 2019

Conversation

@corinagum
Copy link
Member

corinagum commented Oct 14, 2019

#1771

This PR fixes the styling for the <DefaultButton> (Cancel button on dialogs) component, which previously was not high enough contrast. I got these specs from @DesignPolice, which are borrowing a bit from v.next design (Fluent) for styling / simplicity of implementation. Using colors available in neutral.css was complicated and started a chain reaction in color-swaps, so this is the simple alternative we went with.

Please see below for a gif overview of what the default button now looks like in all three themes. No testing added.

defaultButton

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 14, 2019

Coverage Status

Coverage remained the same at 66.897% when pulling 0a0716e on corinagum/1771 into 8aa6bd4 on master.

@cwhitten cwhitten merged commit d5a714a into master Oct 15, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #83271 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the corinagum/1771 branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.