Fluent: fix classes clash between component and fluent packages#5326
Merged
Conversation
8fa6321 to
80d60e9
Compare
compulim
reviewed
Oct 15, 2024
compulim
reviewed
Oct 15, 2024
compulim
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
This PR addresses a critical issue where CSS class names were clashing between the component and fluent packages in Web Chat. The conflict was causing unexpected styling behaviors and potential visual inconsistencies across different themes.
Design
The solution implements a more specific CSS selector strategy for decorator to ensure that styles are applied correctly without interfering with each other:
This fix is temporary. We are considering two potential long-term solutions:
Once a more robust solution becomes available, we plan to revert the classes change.
Specific Changes
BorderFlair.module.css:.border-flairand.border-flair--completeselectorsBorderLoader.module.css:.border-loader,.border-loader__track, and.border-loader__loaderselectorsActivityDecorator.module.cssin the fluent-theme package:.border-loaderand.border-loader__trackselectors-
CHANGELOG.mdI have updated documentationReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed