Skip to content

Fluent: QoL improvements#5327

Merged
OEvgeny merged 7 commits into
mainfrom
fix/minify-css-ci
Oct 17, 2024
Merged

Fluent: QoL improvements#5327
OEvgeny merged 7 commits into
mainfrom
fix/minify-css-ci

Conversation

@OEvgeny
Copy link
Copy Markdown
Collaborator

@OEvgeny OEvgeny commented Oct 16, 2024

Changelog Entry

Fixed

  • Resolved CSS class name conflicts between component and fluent packages to prevent styling issues, in PR #5326, in PR #5327, by @OEvgeny

Description

This PR improves the test environment and implements a better short-term fix for CSS classes clashing.

Specific Changes

  • Updated BorderFlair.module.css, BorderLoader.module.css, and ActivityDecorator.module.css:
    • Reverted to single-class selectors previous fix.
  • Modified Theme.module.css in the fluent-theme package:
    • Added a list of single-letter classes in the global scope to prevent usage by esbuild.
  • Updated tsup.base.config.ts:
    • Enabled minification for the test environment to better simulate production conditions.
  • Modified docker-compose-wsl2.yml:
    • Exposed port 5081 to improve local testing.

-

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny changed the title Check CI Fluent: QoL improvements Oct 16, 2024
@OEvgeny OEvgeny marked this pull request as ready for review October 16, 2024 23:20
Comment thread packages/fluent-theme/src/components/theme/Theme.module.css
@OEvgeny OEvgeny merged commit 7f4b09c into main Oct 17, 2024
@OEvgeny OEvgeny deleted the fix/minify-css-ci branch October 17, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants