The State enum members are lowerCamelCase. Other enums are PascalCase (e.g. TxStatus). The JSON serialization converts some of the enums to UPPERCASE via custom functions.
The Microsoft REST API guidelines say that enum members should be lowerCamelCase. I suggest either standardizing on lowerCameCase in the code (even though it looks a bit funny) and removing any custom conversion functions, or using PascalCase in the code and adding/changing conversion functions everywhere to make them lowerCamelCase in endpoint responses.
This also has an effect on enum members used as part of a request, e.g. status query param in /network/nodes, so it has to work both directions.
The
Stateenum members are lowerCamelCase. Other enums are PascalCase (e.g.TxStatus). The JSON serialization converts some of the enums to UPPERCASE via custom functions.The Microsoft REST API guidelines say that enum members should be lowerCamelCase. I suggest either standardizing on lowerCameCase in the code (even though it looks a bit funny) and removing any custom conversion functions, or using PascalCase in the code and adding/changing conversion functions everywhere to make them lowerCamelCase in endpoint responses.
This also has an effect on enum members used as part of a request, e.g.
statusquery param in /network/nodes, so it has to work both directions.