Skip to content

Late joiners plus view changes#1001

Merged
olgavrou merged 35 commits intomasterfrom
view_changes
Apr 1, 2020
Merged

Late joiners plus view changes#1001
olgavrou merged 35 commits intomasterfrom
view_changes

Conversation

@olgavrou
Copy link
Contributor

@olgavrou olgavrou commented Mar 27, 2020

Resolves #837
Resolves #859

  • if a request has been executed on view v for a majority of replicas but but is executed during the view change from v to v' on a different replica, then the request is seen as executed on view v. This means it will be encrypted with view v set in the IV and the pre-prepare will be stored in the ledger with view v for this replica
  • various small bug fixes
  • global commit is called on commit and not on prepare (PBFT should globally commit on commit not on prepare #859) except for when f == 0 where we need to globally commit earlier
  • remove test_UDP_with_delays and related files

late joiners test changed slightly to avoid adding nodes after the network has been opened as we don't currently support reconfiguration with pbft. It now starts with 3 active replicas, and the late joiner is the fourth replica

@olgavrou olgavrou requested a review from a team as a code owner March 27, 2020 09:41
@ghost
Copy link

ghost commented Mar 27, 2020

view_changes@6885 aka 20200401.3 vs master ewma over 50 builds from 6077 to 6882
images

@ghost
Copy link

ghost commented Mar 27, 2020

view_changes@6765 aka 20200327.83 vs master ewma over 30 builds from 6191 to 6754
images

@microsoft microsoft deleted a comment from olgavrou Mar 30, 2020
@microsoft microsoft deleted a comment from olgavrou Mar 30, 2020
@microsoft microsoft deleted a comment from olgavrou Mar 30, 2020
@olgavrou olgavrou merged commit cf36e71 into master Apr 1, 2020
@olgavrou olgavrou deleted the view_changes branch April 1, 2020 07:46
@ashamis ashamis mentioned this pull request May 5, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PBFT should globally commit on commit not on prepare Pre prepares need to be stored with the same view in the kv

3 participants