Conversation
|
view_changes@6885 aka 20200401.3 vs master ewma over 50 builds from 6077 to 6882 |
|
view_changes@6765 aka 20200327.83 vs master ewma over 30 builds from 6191 to 6754 |
achamayou
reviewed
Mar 29, 2020
achamayou
requested changes
Mar 29, 2020
ashamis
reviewed
Mar 29, 2020
achamayou
reviewed
Mar 30, 2020
achamayou
reviewed
Mar 30, 2020
ashamis
reviewed
Mar 30, 2020
ashamis
reviewed
Mar 30, 2020
ashamis
reviewed
Mar 30, 2020
ashamis
reviewed
Mar 30, 2020
ashamis
reviewed
Mar 30, 2020
ashamis
reviewed
Mar 31, 2020
ashamis
reviewed
Mar 31, 2020
ashamis
reviewed
Mar 31, 2020
achamayou
approved these changes
Mar 31, 2020
ashamis
approved these changes
Mar 31, 2020
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Resolves #837
Resolves #859
vfor a majority of replicas but but is executed during the view change fromvtov'on a different replica, then the request is seen as executed on viewv. This means it will be encrypted with viewvset in the IV and the pre-prepare will be stored in the ledger with viewvfor this replicaf == 0where we need to globally commit earliertest_UDP_with_delaysand related fileslate joiners test changed slightly to avoid adding nodes after the network has been opened as we don't currently support reconfiguration with pbft. It now starts with 3 active replicas, and the late joiner is the fourth replica