Snapshot Term/whole TxID in KV so as to report status correctly in multi-threaded configuration#1288
Merged
achamayou merged 14 commits intomicrosoft:masterfrom Jun 15, 2020
achamayou:kv_txid
Merged
Snapshot Term/whole TxID in KV so as to report status correctly in multi-threaded configuration#1288achamayou merged 14 commits intomicrosoft:masterfrom achamayou:kv_txid
achamayou merged 14 commits intomicrosoft:masterfrom
achamayou:kv_txid
Conversation
…lti-threaded configuration
Closed
|
kv_txid@9429 aka 20200615.54 vs master ewma over 50 builds from 8847 to 9426 |
Member
Author
|
Depends on #1286 |
eddyashton
reviewed
Jun 15, 2020
eddyashton
reviewed
Jun 15, 2020
eddyashton
reviewed
Jun 15, 2020
Co-authored-by: Eddy Ashton <ashton.eddy@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1288 +/- ##
==========================================
- Coverage 67.34% 67.32% -0.01%
==========================================
Files 122 122
Lines 9375 9426 +51
==========================================
+ Hits 6313 6346 +33
- Misses 3062 3080 +18
|
jumaffre
reviewed
Jun 15, 2020
jumaffre
approved these changes
Jun 15, 2020
eddyashton
approved these changes
Jun 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #1252
In a nutshell, this change means that the KV is always made aware of what
view(*) transactions are executing in. This enables accurate Transaction ID reporting in a multi-threaded context.(*) although it really is the
view, and that's how it's communicated externally to users, the code deliberately refers to it asterminternally, because there's already a concept called aviewin the KV, which is really aTxTableView. Naming is hard. I'm open to suggestions here.