Do not drop client signature if transaction conflict#1346
Merged
jumaffre merged 4 commits intomicrosoft:masterfrom Jun 29, 2020
Merged
Do not drop client signature if transaction conflict#1346jumaffre merged 4 commits intomicrosoft:masterfrom
jumaffre merged 4 commits intomicrosoft:masterfrom
Conversation
|
signature_storage_on_conflict@10027 aka 20200626.36 vs master ewma over 50 builds from 9494 to 10019 |
achamayou
approved these changes
Jun 26, 2020
eddyashton
approved these changes
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we drop all views when a transaction conflicts (rightly so!), we need to make sure that the client signature is not dropped if the execution of our RPC endpoint conflicts.