Skip to content

Build, publish and use (in containers) .deb#1443

Merged
achamayou merged 35 commits intomicrosoft:masterfrom
achamayou:cpack
Jul 31, 2020
Merged

Build, publish and use (in containers) .deb#1443
achamayou merged 35 commits intomicrosoft:masterfrom
achamayou:cpack

Conversation

@achamayou
Copy link
Member

@achamayou achamayou commented Jul 27, 2020

fix #698

Conversion from .tgz to single .deb:

  • Make a .deb rather than a .tar.gz
  • Test install that .deb
  • Use .deb to make build an run containers, rather than .tgz

Still to do: split ccf from ccf-dev

  • ccf:
    • cchost
    • no scripts? everything in ccf pypi package?
    • depends on intel psw, libc++/abi and libuv
  • ccf-dev
  • full install, .a and headers
  • still no scripts? everything in ccf pypi package?
  • depends on open-enclave, and many other -dev packages
  • ccf_build role continues to exist with useful utilities that aren't required to build a ccf app but are useful to run end to end tests etc.

@ghost
Copy link

ghost commented Jul 27, 2020

cpack@11436 aka 20200731.9 vs master ewma over 50 builds from 10786 to 11418
images

@codecov-commenter
Copy link

Codecov Report

Merging #1443 into master will increase coverage by 0.30%.
The diff coverage is 64.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1443      +/-   ##
==========================================
+ Coverage   68.70%   69.00%   +0.30%     
==========================================
  Files         126      126              
  Lines       10212    10274      +62     
==========================================
+ Hits         7016     7089      +73     
+ Misses       3196     3185      -11     
Flag Coverage Δ
#unit_ 69.00% <64.20%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/apps/lua_generic/lua_generic.cpp 74.19% <0.00%> (+0.79%) ⬆️
src/ds/ccf_exception.h 0.00% <ø> (ø)
src/ds/json.h 86.71% <ø> (+1.73%) ⬆️
src/ds/logger.h 49.48% <0.00%> (ø)
src/ds/messaging.h 100.00% <ø> (ø)
src/ds/non_blocking.h 79.57% <ø> (ø)
src/ds/ring_buffer_types.h 78.95% <ø> (ø)
src/ds/stacktrace_utils.h 0.00% <ø> (ø)
src/enclave/rpc_context.h 73.33% <ø> (ø)
src/enclave/rpc_handler.h 50.00% <0.00%> (ø)
... and 49 more

@achamayou achamayou changed the title Initial cpack setup Build, publish and use (in containers) .deb Jul 30, 2020
@achamayou achamayou marked this pull request as ready for review July 30, 2020 15:57
@achamayou achamayou requested a review from a team as a code owner July 30, 2020 15:57
@achamayou achamayou merged commit e549cf1 into microsoft:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install directory should be packaged as .deb

3 participants