Fix memory range check on ecall#1553
Merged
achamayou merged 2 commits intoSep 1, 2020
Merged
Conversation
ashamis
approved these changes
Sep 1, 2020
|
fix_memory_check_on_ecall_args@12158 aka 20200901.12 vs master ewma over 50 builds from 11648 to 12155 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adjustment to #1492, which introduced range checks that weren't quite right. We want to check that the entire buffer subject to user_check is strictly outside enclave memory (https://github.com/openenclave/openenclave/blob/b9ae53c1e580fd1af4760f914d53cba1650068ae/include/openenclave/enclave.h#L105) and fail if it's not.
Current code instead checks for strictly in-enclave buffers, and would therefore be satisfied by a partially in-enclave buffer.
Thank you to Zhaofeng Chen, Qinkun Bao, Mingshen Sun, and Kang Li from Baidu Security for spotting and reporting this issue.