js: pass request object as function argument & return response object#1604
Merged
Conversation
|
letmaik/js-request-arg@12689 aka 20200914.8 vs master ewma over 50 builds from 12087 to 12686 |
Member
Author
|
I'll extend this PR a bit more to also include returning a response object containing the body, status code, and headers. Then the low-level request/response interface is more or less complete I think. |
eddyashton
reviewed
Sep 11, 2020
| int argc = 0; | ||
| JSValueConst* argv = nullptr; | ||
| int argc = 1; | ||
| JSValueConst* argv = (JSValueConst *)&request; |
Member
There was a problem hiding this comment.
Minor: this is supposed to be a (C-style) array, can we make it look more like one? Something like JSValueConst argv[] = {&request};?
Member
Author
There was a problem hiding this comment.
I don't think it works like that, compiler is complaining as well: a value of type "JSValue *" cannot be used to initialize an entity of type "int32_t".
eddyashton
approved these changes
Sep 11, 2020
achamayou
approved these changes
Sep 11, 2020
letmaik
changed the title
achamayou
approved these changes
Sep 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and expose the URL path parameters as well.