test_illegal talks to primary, not hardcoded node#1682
Merged
achamayou merged 5 commits intoOct 1, 2020
Conversation
jumaffre
approved these changes
Oct 1, 2020
|
test_illegal_talk_to_real_node@13475 aka 20201001.6 vs master ewma over 50 builds from 12816 to 13466 |
achamayou
reviewed
Oct 1, 2020
| @reqs.supports_methods("log/private", "log/public") | ||
| @reqs.at_least_n_nodes(2) | ||
| def test_illegal(network, args, verify=True): | ||
| primary, _ = network.find_primary() |
Member
There was a problem hiding this comment.
Technically this can be any node.
achamayou
approved these changes
Oct 1, 2020
eddyashton
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an occasional error in
full_test_suite.Includes some changes to
CHANGELOG.md