Skip to content

JWT validation in forum sample#1867

Merged
jumaffre merged 6 commits into
microsoft:masterfrom
letmaik:letmaik/tsoa-jwt-validation
Nov 11, 2020
Merged

JWT validation in forum sample#1867
jumaffre merged 6 commits into
microsoft:masterfrom
letmaik:letmaik/tsoa-jwt-validation

Conversation

@letmaik
Copy link
Copy Markdown
Member

@letmaik letmaik commented Nov 9, 2020

This also removes the guest user mode on the website. For tests and bulk import during demos a separate JWT signing key is generated and imported to avoid having to use real Microsoft identities.

@letmaik letmaik requested a review from a team as a code owner November 9, 2020 13:49
@ghost
Copy link
Copy Markdown

ghost commented Nov 9, 2020

letmaik/tsoa-jwt-validation@15304 aka 20201111.17 vs master ewma over 50 builds from 14771 to 15287
images

Comment thread samples/apps/forum/src/authentication.ts Outdated
Comment thread samples/apps/forum/src/controllers/site.ts Outdated
Comment thread samples/apps/forum/src/authentication.ts Outdated
@letmaik
Copy link
Copy Markdown
Member Author

letmaik commented Nov 10, 2020

@achamayou Can you fix the merge conflicts here? The idea was to merge this PR before the prettier PR :)

@achamayou
Copy link
Copy Markdown
Member

@letmaik sorry, I was not aware this was the idea. For what it's worth, ./scripts/ci-checks.sh -f will automatically format everything happily.

@letmaik letmaik force-pushed the letmaik/tsoa-jwt-validation branch from 3a1d054 to 075854b Compare November 11, 2020 10:07
@letmaik letmaik mentioned this pull request Nov 11, 2020
@letmaik letmaik linked an issue Nov 11, 2020 that may be closed by this pull request
@letmaik
Copy link
Copy Markdown
Member Author

letmaik commented Nov 11, 2020

@achamayou All green :)

@jumaffre jumaffre merged commit 5db9943 into microsoft:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JWT validation in forum sample app

3 participants