Skip to content

Add JWT public signing key auto-refresh#1908

Merged
achamayou merged 21 commits into
microsoft:masterfrom
letmaik:letmaik/jwt-key-auto-refresh
Nov 23, 2020
Merged

Add JWT public signing key auto-refresh#1908
achamayou merged 21 commits into
microsoft:masterfrom
letmaik:letmaik/jwt-key-auto-refresh

Conversation

@letmaik
Copy link
Copy Markdown
Member

@letmaik letmaik commented Nov 20, 2020

Implements #1893.

Follow-up PRs (not necessarily all by myself):

  • Expose connection failures to enclave to be able to record key refresh errors in those situations
  • In case of any error during key refresh, schedule next task with lower time interval, maybe gradually backing off
  • Do an initial immediate key refresh after KV is synced (not sure where the best place is to trigger this)
  • Move update_ca_cert proposal to C++, currently in Lua. Also, rename to set_ca_cert and add remove_ca_cert proposal.

@letmaik letmaik requested a review from a team as a code owner November 20, 2020 12:23
@ghost
Copy link
Copy Markdown

ghost commented Nov 20, 2020

letmaik/jwt-key-auto-refresh@15658 aka 20201123.18 vs master ewma over 50 builds from 15114 to 15645
images

Comment thread src/node/node_state.h Outdated
Comment thread src/node/node_state.h Outdated
Comment thread src/node/node_state.h Outdated
Comment thread src/node/rpc/endpoint_registry.h
Comment thread src/node/rpc/member_frontend.h
Comment thread src/runtime_config/gov.lua
Comment thread src/host/main.cpp
Comment thread src/node/node_state.h Outdated
Comment thread src/node/node_state.h Outdated
Comment thread src/node/node_state.h Outdated
Comment thread src/node/rpc/member_frontend.h
Comment thread tests/jwt_test.py Outdated
@achamayou achamayou merged commit 6528a33 into microsoft:master Nov 23, 2020
@letmaik letmaik deleted the letmaik/jwt-key-auto-refresh branch November 24, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants