Cleanup tls client#1964
Merged
Merged
Conversation
|
cleanup_tls_client@16082 aka 20201201.24 vs master ewma over 50 builds from 15423 to 16079 |
Member
Author
|
Although this doesn’t solve #1701, I think this is still a worthwhile change. |
eddyashton
reviewed
Dec 1, 2020
eddyashton
requested changes
Dec 1, 2020
Member
eddyashton
left a comment
There was a problem hiding this comment.
I don't think this fixes the original linked issue. If we throw in connect(), we throw in the constructor of TlsClient, meaning we don't call the default destructor ~TlsClient(), and in turn we don't call the destructors of the members or the relevant _free functions. We either need to pepper connect() with _frees, or maybe:
TlsClient()
{
try
{
connect();
}
catch (const std::exception&)
{
disconnect();
throw;
}
}
Member
Author
|
@eddyashton yes, you're right, I completely missed that. |
eddyashton
reviewed
Dec 1, 2020
Co-authored-by: Eddy Ashton <ashton.eddy@gmail.com>
eddyashton
approved these changes
Dec 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fix #738