Return 204 on /ack success instead of JSON true#2088
Conversation
|
@letmaik thank you, that looks good. Since this is a REST API change, would you mind adding an entry to CHANGELOG.md? We could use https://github.com/openapi-tools/open-api-diff, the markdown diff looks quite reasonable, and may even be generated automatically on release. |
Will do, I always forget. I just realized that CCF only supports |
|
Pinging @eddyashton, I think it's just a matter of adding a default argument to set_auto_schema() and using it line 337? |
|
Yes - what @achamayou said should be sufficient. |
|
letmaik/ack-204@17695 aka 20210118.29 vs master ewma over 50 builds from 17034 to 17692 |
Co-authored-by: Eddy Ashton <ashton.eddy@gmail.com>
|
@achamayou @eddyashton I had to do a bit more plumbing but I think I ended up at something good. If |
|
@letmaik that does seem like a sensible default, but we may still want to support user-defined 2xx, like Created etc in the future. Agree it's out of scope for this change though. |
This PR allows specifiying a custom status code. Isn't that what you mean? |

Addresses first point of #1944.