Combine view and seqno into single HTTP header#2257
Merged
Conversation
|
single_tx_id_header@19866 aka 20210303.10 vs main ewma over 20 builds from 19626 to 19856 |
achamayou
reviewed
Mar 3, 2021
achamayou
reviewed
Mar 3, 2021
achamayou
approved these changes
Mar 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2256.
The format of this header is
{view}.{seqno}, with no other decoration. Any decoration we do add to aid parsing should be safe to insert as a URL query parameter.Also creates public header file for this
ccf::TxID. This should be used more broadly within CCF, replacing a few similar duplicated structs, but I don't want that to pollute this PR.There are other places in the API (notably
/tx) where we still talk about view and seqno separately. These could be consolidated into a single field, but they're not directly tied to this change.