Use hash of certificate for user and member IDs#2279
Merged
Conversation
added 12 commits
March 5, 2021 09:54
|
member_id_hash_cert@20196 aka 20210310.28 vs main ewma over 20 builds from 19816 to 20184 |
jumaffre
commented
Mar 8, 2021
eddyashton
reviewed
Mar 8, 2021
eddyashton
reviewed
Mar 8, 2021
eddyashton
reviewed
Mar 8, 2021
Co-authored-by: Eddy Ashton <ashton.eddy@gmail.com>
…mber_id_hash_cert
achamayou
reviewed
Mar 9, 2021
added 4 commits
March 9, 2021 15:18
eddyashton
reviewed
Mar 9, 2021
achamayou
reviewed
Mar 9, 2021
achamayou
reviewed
Mar 9, 2021
achamayou
reviewed
Mar 9, 2021
achamayou
approved these changes
Mar 9, 2021
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
…mber_id_hash_cert
…mber_id_hash_cert
…mber_id_hash_cert
…mber_id_hash_cert
eddyashton
approved these changes
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1378 (part II)
We now use a hex-encoded string of the SHA-256 hash of the DER-encoded certificate (a.k.a fingerprint) for the member and user IDs.
This has the following implication: the user and member certs and digests KV tables are gone and the
keyIdin signed HTTP requests is set to the Member/User ID.The Python infra still tracks members/users as
0,1, etc. (local_id) but also knows their CCF IDs (service_id).