Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs comprehensive tidying and modernization of the HTTP-related headers in src/http/, following up on #7493 to apply clang-tidy improvements consistently across the HTTP subsystem.
- Adds HTTP directory to clang-tidy's HeaderFilterRegex for comprehensive static analysis
- Applies modern C++ best practices including
[[nodiscard]]attributes, explicit destructors, and improved const correctness - Fixes a subtle bug where
std::move()was incorrectly used on a const reference parameter
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .clang-tidy | Adds http directory to HeaderFilterRegex for enforcing code quality checks |
| src/kv/kv_types.h | Removes unused forward declaration for aft::Request |
| src/http/http_session.h | Updates parameter naming conventions, removes unnecessary else block, adds proper move semantics |
| src/http/http_rpc_context.h | Adds [[nodiscard]] attributes, removes redundant initializers, improves member initialization |
| src/http/http_proc.h | Adds virtual destructors to base classes for proper polymorphic behavior |
| src/http/http_parser.h | Improves type safety with explicit casts, adds destructors, specifies enum underlying types |
| src/http/http_jwt.h | Specifies enum underlying type, adds member initialization |
| src/http/http_exceptions.h | Adds [[nodiscard]] attribute to getter method |
| src/http/http_builder.h | Adds [[nodiscard]] attributes, removes unnecessary else blocks, improves vector construction |
| src/http/http2_utils.h | Converts C-style casts to explicit reinterpret_cast, removes unnecessary const qualifiers |
| src/http/http2_types.h | Specifies enum underlying type, improves member initialization, adds [[nodiscard]] attributes |
| src/http/http2_session.h | Fixes bug with std::move on const reference, updates parameter naming, removes unnecessary else |
| src/http/http2_parser.h | Improves initialization, adds [[nodiscard]] attributes, uses type traits aliases |
| src/http/http2_callbacks.h | Documents unused parameters with comments, fixes bitwise operation comparison |
| src/http/error_reporter.h | Uses defaulted virtual destructor |
| src/http/curl.h | Improves const correctness, adds safety checks, fixes pointer casting |
eddyashton
reviewed
Dec 4, 2025
eddyashton
reviewed
Dec 4, 2025
eddyashton
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #7493