Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reformats hardcoded certificate and key strings in test files to improve readability by converting awkwardly broken multi-line concatenations into clean, single-line-per-certificate-line format.
- Reformatted three certificate strings and one public key string across two test files
- Changed from fragmented string concatenations to clear line-by-line format with explicit newline characters
- Maintained identical certificate content while improving code readability
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/crypto/test/pem.cpp | Reformatted a test certificate string from fragmented concatenation to clean line-by-line format |
| src/crypto/test/crypto.cpp | Reformatted one public key string and two certificate strings (with \n and \r\n line endings respectively) for better readability |
eddyashton
approved these changes
Dec 4, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a couple of canned certs which were horribly formatted.
This tidies them up.