Skip to content

YAML anchors for all verbose conditions, and precise label triggering conditions #7535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
achamayou merged 6 commits into from
Dec 17, 2025
Merged

YAML anchors for all verbose conditions, and precise label triggering conditions #7535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0433738
Anchors for all label trigger conditions
eddyashton Dec 16, 2025
9ad602c
Ignore the language server - try a complex condition
eddyashton Dec 16, 2025
f366516
YAML single quotes
eddyashton Dec 16, 2025
280fef4
Trust the robot
eddyashton Dec 16, 2025
14d109e
Merge branch 'main' into yaml_label_trigger_sanitisation
achamayou Dec 16, 2025
597bc79
Merge branch 'main' into yaml_label_trigger_sanitisation
achamayou Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/bencher-ab.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,15 @@ jobs:
1ES.Pool=gha-vmss-d16av5-ci,
"JobId=bab_benchmark_pr-${{ github.run_id }}-${{ github.run_number }}-${{ github.run_attempt }}",
]
if: ${{ contains(github.event.pull_request.labels.*.name, 'bench-ab') || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule'}}
if: &check_trigger_conditions >-
${{
(github.event.action == 'labeled'
&& github.event.label.name == 'bench-ab')
|| (github.event.action != 'labeled'
&& contains(github.event.labels.*.name, 'bench-ab'))
|| github.event_name == 'workflow_dispatch'
|| github.event_name == 'schedule'
}}
container:
image: mcr.microsoft.com/azurelinux/base/core:3.0
options: --user root
Expand Down Expand Up @@ -72,7 +80,7 @@ jobs:
1ES.Pool=gha-vmss-d16av5-ci,
"JobId=bab_benchmark_main-${{ github.run_id }}-${{ github.run_number }}-${{ github.run_attempt }}",
]
if: ${{ contains(github.event.pull_request.labels.*.name, 'bench-ab') || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule'}}
if: *check_trigger_conditions
container:
image: mcr.microsoft.com/azurelinux/base/core:3.0
options: --user root
Expand Down Expand Up @@ -127,7 +135,7 @@ jobs:
image: mcr.microsoft.com/azurelinux/base/core:3.0
options: --user root
needs: [benchmark_pr, benchmark_main]
if: ${{ contains(github.event.pull_request.labels.*.name, 'bench-ab') || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule'}}
if: *check_trigger_conditions
steps:
- name: Setup container dependencies
run: |
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/long-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,15 @@ permissions: read-all

jobs:
long-asan:
if: &check_trigger_conditions ${{ contains(github.event.pull_request.labels.*.name, 'run-long-test') || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule'}}
if: &check_trigger_conditions >-
${{
(github.event.action == 'labeled'
&& github.event.label.name == 'run-long-test')
|| (github.event.action != 'labeled'
&& contains(github.event.labels.*.name, 'run-long-test'))
|| github.event_name == 'workflow_dispatch'
|| github.event_name == 'schedule'
}}
name: "ASAN"
runs-on:
[
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/long-verification.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,15 @@ permissions: read-all
jobs:
model-checking-with-atomic-reconfig-consensus:
name: Model Checking With Atomic Reconfig - Consensus
if: ${{ contains(github.event.pull_request.labels.*.name, 'run-long-verification') || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' }}
if: &check_trigger_conditions >-
${{
(github.event.action == 'labeled'
&& github.event.label.name == 'run-long-verification')
|| (github.event.action != 'labeled'
&& contains(github.event.labels.*.name, 'run-long-verification'))
|| github.event_name == 'workflow_dispatch'
|| github.event_name == 'schedule'
}}
runs-on:
[
self-hosted,
Expand Down Expand Up @@ -58,7 +66,7 @@ jobs:

model-checking-with-reconfig-consensus:
name: Model Checking With Reconfig - Consensus
if: ${{ contains(github.event.pull_request.labels.*.name, 'run-long-verification') || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' }}
if: *check_trigger_conditions
runs-on:
[
self-hosted,
Expand Down Expand Up @@ -96,7 +104,7 @@ jobs:

simulation-consensus:
name: Simulation - Consensus
if: ${{ contains(github.event.pull_request.labels.*.name, 'run-long-verification') || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' }}
if: *check_trigger_conditions
runs-on: ubuntu-latest
defaults:
run:
Expand Down