Skip to content

In ci-checks.sh, call endgroup before exiting#7536

Merged
achamayou merged 1 commit intomicrosoft:mainfrom
eddyashton:ci_checks_end_group
Dec 16, 2025
Merged

In ci-checks.sh, call endgroup before exiting#7536
achamayou merged 1 commit intomicrosoft:mainfrom
eddyashton:ci_checks_end_group

Conversation

@eddyashton
Copy link
Copy Markdown
Member

Otherwise you stay inside a nested group when the script ends, folding subsequent input:

image image

@eddyashton eddyashton requested a review from a team as a code owner December 16, 2025 14:16
Copilot AI review requested due to automatic review settings December 16, 2025 14:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a group folding issue in the CI checks script where the "Summary" group wasn't being properly closed before script exit, causing subsequent output to be incorrectly folded in GitHub Actions logs.

  • Moves endgroup call to execute before both exit points in the Summary section
  • Ensures proper cleanup of GitHub Actions workflow groups regardless of success or failure

@achamayou achamayou merged commit 9413aaf into microsoft:main Dec 16, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants