More fiddling with YAML workflow conditions#7537
Merged
eddyashton merged 4 commits intomicrosoft:mainfrom Dec 17, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the complex workflow trigger conditions that were introduced in #7535, which didn't work correctly (jobs were being skipped). The changes simplify the label-checking logic back to a straightforward approach.
Key changes:
- Removed complex conditional logic that attempted to distinguish between
labeledand non-labeledactions - Reverted to simpler
contains()check for label presence across all three workflow files
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/long-verification.yml |
Simplified trigger conditions to use basic label containment check for run-long-verification label |
.github/workflows/long-test.yml |
Simplified trigger conditions to use basic label containment check for run-long-test label |
.github/workflows/bencher-ab.yml |
Simplified trigger conditions to use basic label containment check for bench-ab label |
…st object to placate language server
eddyashton
changed the title
cjen1-msft
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added in #7535, looks like they don't work (skipped jobs since this merged).