Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses issue #7631 by improving error handling for malformed JWT tokens. Previously, when a JWT token contained invalid base64url encoding, the system would return a 500 Internal Server Error with an obscure OpenSSL error message. With these changes, the system now returns a 401 Unauthorized response with clearer, user-friendly error messages.
Changes:
- Added error handling for base64url decoding failures in JWT parsing with specific error messages for each component (header, payload, signature)
- Added comprehensive test coverage for various malformed JWT token formats
- Test validates that all malformed tokens return 401 status codes with appropriate error messages
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/http/http_jwt.h | Introduced parse_jwt_b64url helper function to catch base64url decoding exceptions and convert them to 401 errors with clear error messages |
| tests/jwt_test.py | Added test_malformed_tokens function to verify malformed JWTs return 401 with correct error messages, including test cases for wrong number of parts and invalid base64url in each component |
eddyashton
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7631 - @ivarprudnikov can you have a look please?