Improve argument for snapshot triggering chunk generation#7664
Merged
achamayou merged 3 commits intomicrosoft:mainfrom Feb 12, 2026
Merged
Improve argument for snapshot triggering chunk generation#7664achamayou merged 3 commits intomicrosoft:mainfrom
achamayou merged 3 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ledger snapshot operations documentation to better justify why forcing snapshot generation also forces a ledger chunk boundary, ensuring nodes that join from a snapshot produce ledger chunk files consistent with the primary.
Changes:
- Replaces invariant #4 to explain the join-from-snapshot scenario and why a new ledger file must begin immediately after a snapshot’s seqno.
- Expands the reasoning tying snapshot generation to ledger chunk boundaries and cross-node chunk consistency.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
eddyashton
approved these changes
Feb 12, 2026
achamayou
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.