Enhance recovery local unsealing function to accept a suffix for labels#7685
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the SNP end-to-end recovery/local-unsealing test helper to use explicit, caller-provided label suffixes rather than auto-generated parameter-based labels, to make test runs easier to identify/grep in workspace output.
Changes:
- Add a
suffixparameter torun_recovery_local_unsealing()and append it toargs.label. - Update SNP test invocations to pass explicit suffixes for the non-default variants (rekey, shares refresh, f=1).
achamayou
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't like these auto-generated names with all of the parameters - let's name them explicitly (more greppable).