Fix common_ipv6 test failures on runners without IPv6 support#7732
Merged
achamayou merged 2 commits intoipv6_experimentfrom Mar 11, 2026
Merged
Fix common_ipv6 test failures on runners without IPv6 support#7732achamayou merged 2 commits intoipv6_experimentfrom
achamayou merged 2 commits intoipv6_experimentfrom
Conversation
…SANs Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues with experimental support for IPv6
Fix common_ipv6 test failures on runners without IPv6 support
Mar 11, 2026
achamayou
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
common_ipv6test unconditionally attempts to bind CCF nodes to::1, causinguv_tcp_bindto fail and the node process to abort on CI runners where IPv6 is disabled at the OS level.Changes
tests/e2e_common_endpoints.py: Guardrun_ipv6with a pre-flight check — attemptsocket.bind(("::1", 0))before starting any nodes; skip with a warning if IPv6 loopback is unavailable. Added missingimport socketandimport infra.interfaces.src/node/node_state.h: Strip brackets from IPv6 hosts inget_subject_alternative_names()before SAN construction. Without this, whenpublished_addressfalls back tobind_address(which uses bracket notation, e.g.[::1]:8080), the SAN is incorrectly emitted asDNS:[::1]instead ofIP:::1. Updatedis_ip()comment to drop the "untested" qualifier for IPv6.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.