Merged
Conversation
achamayou
reviewed
Mar 18, 2026
achamayou
added
auto-backport
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the SEV-SNP Turin CPUID encoding and adds a regression test to ensure CPUID<->product mappings remain consistent.
Changes:
- Update Turin CPUID hex value returned by
get_cpuid_of_snp_sev_product. - Add documentation links to AMD revision guides for each product’s CPUID mapping.
- Simplify an exception-message assertion and add a new CPUID mapping roundtrip test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/pal/test/snp_attestation_validation.cpp | Refactors an exception assertion and adds a CPUID/product roundtrip regression test. |
| include/ccf/pal/sev_snp_cpuid.h | Fixes Turin CPUID hex mapping and documents sources for the CPUID values. |
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
achamayou
reviewed
Mar 18, 2026
achamayou
approved these changes
Mar 18, 2026
cjen1-msft
added a commit
to cjen1-msft/CCF
that referenced
this pull request
Mar 18, 2026
Co-authored-by: Amaury Chamayou <amaury@xargs.fr> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
cjen1-msft
added a commit
to cjen1-msft/CCF
that referenced
this pull request
Mar 19, 2026
Co-authored-by: Amaury Chamayou <amaury@xargs.fr> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
achamayou
added a commit
that referenced
this pull request
Mar 19, 2026
) (#7752) Co-authored-by: Eddy Ashton <ashton.eddy@gmail.com> Co-authored-by: Amaury Chamayou <amaury@xargs.fr> Co-authored-by: Amaury Chamayou <amchamay@microsoft.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the Turin CPUID and also add a test to prevent future regressions.