Remove trailing semicolons after constructor body braces#7777
Remove trailing semicolons after constructor body braces#7777Copilot wants to merge 3 commits intocopilot/fix-issue-7742from
Conversation
|
@copilot This PR should be targeting |
…on removal Co-authored-by: eddyashton <6000239+eddyashton@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/4e786471-89ea-44ad-b5b5-758d244e917b
The branch has been updated so the net diff vs Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot I can't edit the base branch, since this is your PR. Create a fresh PR correctly targeting main. Close this. |
|
@eddyashton I've opened a new pull request, #7778, to work on those changes. Once the pull request is ready, I'll request review from you. |
Trailing semicolons after
{}in constructor definitions were causing inconsistent clang-format output between versions (Ubuntu vs Azure Linux). This removes them across the affected files.Changes
src/endpoints/authentication/cose_auth.cpp—MemberCOSESign1AuthnPolicyctorsrc/js/extensions/ccf/historical.cpp—Implctorsrc/js/extensions/ccf/kv.cpp—Implctorsrc/node/quote_endorsements_client.h—QuoteEndorsementsClientctorBefore:
Impl(ccf::kv::Tx* t) : tx(t){};After:
Impl(ccf::kv::Tx* t) : tx(t) {}🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.