Skip to content

Remove trailing semicolons after constructor body braces#7777

Closed
Copilot wants to merge 3 commits intocopilot/fix-issue-7742from
copilot/sub-pr-7775
Closed

Remove trailing semicolons after constructor body braces#7777
Copilot wants to merge 3 commits intocopilot/fix-issue-7742from
copilot/sub-pr-7775

Conversation

Copy link
Contributor

Copilot AI commented Mar 26, 2026

Trailing semicolons after {} in constructor definitions were causing inconsistent clang-format output between versions (Ubuntu vs Azure Linux). This removes them across the affected files.

Changes

  • src/endpoints/authentication/cose_auth.cppMemberCOSESign1AuthnPolicy ctor
  • src/js/extensions/ccf/historical.cppImpl ctor
  • src/js/extensions/ccf/kv.cppImpl ctor
  • src/node/quote_endorsements_client.hQuoteEndorsementsClient ctor

Before:

Impl(ccf::kv::Tx* t) : tx(t){};

After:

Impl(ccf::kv::Tx* t) : tx(t) {}

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI changed the title [WIP] [WIP] Remove trailing semicolons in separate PR Remove trailing semicolons after constructor body braces Mar 26, 2026
Copilot AI requested a review from eddyashton March 26, 2026 12:02
@eddyashton
Copy link
Member

@copilot This PR should be targeting main.

Copy link
Contributor Author

Copilot AI commented Mar 26, 2026

@copilot This PR should be targeting main.

The branch has been updated so the net diff vs main contains only the 4 trailing semicolon removals (commit b70c6963). I'm unable to change the PR base branch programmatically — could you update the base from copilot/fix-issue-7742 to main via the GitHub UI? (Click "Edit" next to the base branch selector at the top of the PR.)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh pr view 7777 --repo microsoft/CCF (http block)
    • Triggering command: /usr/bin/gh gh auth status bash sev_�� --noprofile (http block)

If you need me to access, download, or install something from one of these locations, you can either:

@eddyashton
Copy link
Member

@copilot I can't edit the base branch, since this is your PR. Create a fresh PR correctly targeting main. Close this.

Copy link
Contributor Author

Copilot AI commented Mar 26, 2026

@eddyashton I've opened a new pull request, #7778, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants