Skip to content

Deprecate snapshots.read_only_directory configuration option#7800

Merged
achamayou merged 7 commits intomainfrom
copilot/deprecate-snapshot-read-only-dirs
Apr 1, 2026
Merged

Deprecate snapshots.read_only_directory configuration option#7800
achamayou merged 7 commits intomainfrom
copilot/deprecate-snapshot-read-only-dirs

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 1, 2026

snapshots.read_only_directory is being deprecated ahead of removal in a future release.

Changes

  • Schema description (doc/host_config_schema/cchost_config.json): Updated the read_only_directory field description to note it is deprecated.
  • Startup warning (src/host/run.cpp): Emits a LOG_FAIL_FMT warning at startup if snapshots.read_only_directory is set in the config.
  • CHANGELOG: Added a Deprecated entry under [7.0.0-rc1].

Copilot AI changed the title [WIP] Deprecate snapshot read only dirs configuration Deprecate snapshots.read_only_directory configuration option Apr 1, 2026
Copilot AI requested a review from eddyashton April 1, 2026 09:03
Comment thread doc/host_config_schema/cchost_config.json Outdated
…ecation notice

Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/52fe1027-e446-4c81-aeaa-b182e4170a47

Co-authored-by: eddyashton <6000239+eddyashton@users.noreply.github.com>
Copilot AI requested a review from eddyashton April 1, 2026 09:13
Comment thread doc/host_config_schema/cchost_config.json Outdated
@achamayou achamayou marked this pull request as ready for review April 1, 2026 09:49
@achamayou achamayou requested a review from a team as a code owner April 1, 2026 09:49
Copilot AI review requested due to automatic review settings April 1, 2026 09:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Deprecates the snapshots.read_only_directory host configuration option ahead of planned removal, and informs operators via schema notes, startup logging, and changelog entry.

Changes:

  • Marked snapshots.read_only_directory as deprecated in the host config JSON schema.
  • Added a startup log when snapshots.read_only_directory is configured.
  • Documented the deprecation under [7.0.0-rc1] in the changelog.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/host/run.cpp Logs at startup when deprecated config option is present.
doc/host_config_schema/cchost_config.json Updates schema field description to explicitly state deprecation and suggested alternatives.
CHANGELOG.md Adds release note describing deprecation and recommended replacement behavior.

Comment thread src/host/run.cpp Outdated
Comment thread doc/host_config_schema/cchost_config.json
Comment thread CHANGELOG.md
Comment thread src/host/run.cpp Outdated
@achamayou achamayou merged commit fa20ef7 into main Apr 1, 2026
19 checks passed
@achamayou achamayou deleted the copilot/deprecate-snapshot-read-only-dirs branch April 1, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate snapshot read only dirs configuration in 7

5 participants