Conversation
….h private Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/0eeefbbf-f333-4441-9314-6a72738a435d Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
achamayou
April 15, 2026 14:07
View session
eddyashton
reviewed
Apr 16, 2026
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/af731ffa-fdc2-4315-9c2e-f6a5c0b29ce1 Co-authored-by: eddyashton <6000239+eddyashton@users.noreply.github.com>
eddyashton
approved these changes
Apr 16, 2026
achamayou
approved these changes
Apr 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the unused get_responder() method from the public ccf::RpcContext API and relocates http_responder.h from the public headers into a private src/http/ header, updating internal include paths and call sites accordingly.
Changes:
- Removed
RpcContext::get_responder()and its public dependency onccf/http_responder.h. - Updated HTTP session code to stop passing/storing a responder inside
HttpRpcContext. - Moved
http_responder.htosrc/http/and updated includes; documented the API change in the changelog.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| include/ccf/rpc_context.h | Removes get_responder() from the public API and drops the public include dependency. |
| src/http/http_rpc_context.h | Removes responder member/ctor parameter and the override. |
| src/http/http2_session.h | Updates include path and HttpRpcContext construction signature. |
| src/http/http_session.h | Updates include path to the new private responder header. |
| src/enclave/rpc_sessions.h | Updates include path for responder header usage in enclave code. |
| src/http/http_responder.h | Adds the responder interface in its new private location. |
| CHANGELOG.md | Notes the API removal and header privatization under 7.0.0-rc2. |
| #include "enclave/session.h" | ||
| #include "forwarder_types.h" | ||
| #include "http/http2_session.h" | ||
| #include "http/http_responder.h" |
There was a problem hiding this comment.
This file now directly includes http/http_responder.h, but doesn't reference ccf::http::HTTPResponder anywhere (and both http_session.h and http2_session.h already include it). Consider dropping this include to avoid redundant dependencies.
Suggested change
| #include "http/http_responder.h" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_responder()was declared as a pure virtual method in the publicccf::RpcContextAPI but had no call sites anywhere in the codebase. This PR removes it and, as a consequence, moveshttp_responder.hfrom the publicinclude/ccf/directory into the privatesrc/http/directory.Changes
include/ccf/rpc_context.h: Removeget_responder()virtual declaration and the#include "ccf/http_responder.h"it required.src/http/http_rpc_context.h: Removeget_responder()override,respondermember variable, andresponder_constructor parameter; update include to use the new private path.src/http/http2_session.h: Remove the responder argument from theHttpRpcContextconstructor call; update include path.src/http/http_session.h: Update include path.src/enclave/rpc_sessions.h: Update include path.src/http/http_responder.h: New location (moved frominclude/ccf/http_responder.h).CHANGELOG.md: Document the removal under[7.0.0-rc2].