Update Gersemi and make it fail on warnings#7842
Merged
achamayou merged 5 commits intomicrosoft:mainfrom Apr 28, 2026
Merged
Conversation
maxtropets
commented
Apr 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s CMake formatting workflow to use a newer gersemi version and to treat formatter warnings (eg unknown commands) as hard failures, preventing “green” formatting checks when warnings are present.
Changes:
- Bump
gersemifrom0.17.0to0.27.0and enable--warnings-as-errorsin the CMake format check script. - Add a stub definition for
add_fuzz_test()sogersemirecognizes this custom CMake command. - Apply formatter-driven whitespace/inlining changes across several CMake files.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/check-cmake-format.sh | Updates gersemi version and enables warnings-as-errors; adds explicit failure handling for -i. |
| cmake/gersemi_definitions.cmake | Adds stub add_fuzz_test(); minor formatting changes to existing stubs. |
| cmake/common.cmake | Formatter-driven inlining of cmake_parse_arguments(PARSE_ARGV …) calls. |
| cmake/ccf_app.cmake | Formatter-driven inlining of cmake_parse_arguments(PARSE_ARGV …) calls. |
| CMakeLists.txt | Formatter-driven inlining for list(), file(READ), and file(GENERATE) argument layout. |
| .gersemirc | Updates schema URL to match gersemi 0.27.0. |
achamayou
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed during #7839 :
Not good, not terrible.
Added
--warnings-as-errorswhich only exists v0.19 onwards, so decided to go 0.27 at once, because why not.