Log machine info in bencher workflow#7843
Merged
maxtropets merged 2 commits intomainfrom Apr 27, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/1206b4eb-f761-4a6a-873b-a11839fc8f68 Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
maxtropets
April 27, 2026 16:25
View session
maxtropets
approved these changes
Apr 27, 2026
Collaborator
|
@copilot remove it from AB bencher yml |
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/73672337-6879-4879-a386-f49adc610451 Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Contributor
Author
Copilot
AI
changed the title
Log machine info in bencher workflows
Log machine info in bencher workflow
Apr 27, 2026
achamayou
approved these changes
Apr 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a lightweight “Machine info” logging step to the scheduled benchmark workflow so benchmark results can be correlated with the underlying runner hardware/kernel characteristics.
Changes:
- Add a
Machine infostep tobenchmark_virtualto log kernel, CPU, and memory details immediately after checkout. - Add the same
Machine infostep tobenchmark_snpimmediately after checkout.
maxtropets
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark runs land on whatever the 1ES pool hands out, with no record in the logs of which machine actually ran. Add a "Machine info" step to each benchmark job in the scheduled bencher workflow so results can be correlated with hardware.
.github/workflows/bencher.yml— new step inbenchmark_virtualandbenchmark_snp, run right after checkout.Each step runs:
Beyond the requested
cat /proc/cpuinfo,nprocreflects cores actually visible to the container (cgroup-aware, unlike/proc/cpuinfo),/proc/meminfocaptures available RAM, anduname -apins the kernel — all of which materially affect benchmark numbers.Possible follow-ups, not done here to keep the change minimal and dependency-free:
lscpu(cleaner summary, requirestdnf install util-linuxin the Azure Linux container),dmidecode(needs privileged container), or emitting the info as a bencher testbed attribute rather than just to the log.