Skip to content

Log machine info in bencher workflow#7843

Merged
maxtropets merged 2 commits intomainfrom
copilot/add-cat-cpuinfo-to-bencher
Apr 27, 2026
Merged

Log machine info in bencher workflow#7843
maxtropets merged 2 commits intomainfrom
copilot/add-cat-cpuinfo-to-bencher

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 27, 2026

Benchmark runs land on whatever the 1ES pool hands out, with no record in the logs of which machine actually ran. Add a "Machine info" step to each benchmark job in the scheduled bencher workflow so results can be correlated with hardware.

  • .github/workflows/bencher.yml — new step in benchmark_virtual and benchmark_snp, run right after checkout.

Each step runs:

uname -a
nproc
cat /proc/cpuinfo
cat /proc/meminfo

Beyond the requested cat /proc/cpuinfo, nproc reflects cores actually visible to the container (cgroup-aware, unlike /proc/cpuinfo), /proc/meminfo captures available RAM, and uname -a pins the kernel — all of which materially affect benchmark numbers.

Possible follow-ups, not done here to keep the change minimal and dependency-free: lscpu (cleaner summary, requires tdnf install util-linux in the Azure Linux container), dmidecode (needs privileged container), or emitting the info as a bencher testbed attribute rather than just to the log.

Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/1206b4eb-f761-4a6a-873b-a11839fc8f68

Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
@maxtropets
Copy link
Copy Markdown
Collaborator

@copilot remove it from AB bencher yml

Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/73672337-6879-4879-a386-f49adc610451

Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 27, 2026

@copilot remove it from AB bencher yml

Removed in cda8e2fbencher-ab.yml is back to its original state, the Machine info step now only lives in bencher.yml.

Copilot AI changed the title Log machine info in bencher workflows Log machine info in bencher workflow Apr 27, 2026
Copilot AI requested a review from maxtropets April 27, 2026 16:29
@achamayou achamayou marked this pull request as ready for review April 27, 2026 16:30
@achamayou achamayou requested a review from a team as a code owner April 27, 2026 16:30
Copilot AI review requested due to automatic review settings April 27, 2026 16:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a lightweight “Machine info” logging step to the scheduled benchmark workflow so benchmark results can be correlated with the underlying runner hardware/kernel characteristics.

Changes:

  • Add a Machine info step to benchmark_virtual to log kernel, CPU, and memory details immediately after checkout.
  • Add the same Machine info step to benchmark_snp immediately after checkout.

@maxtropets maxtropets enabled auto-merge (squash) April 27, 2026 16:41
@maxtropets maxtropets merged commit e6e41e4 into main Apr 27, 2026
23 checks passed
@maxtropets maxtropets deleted the copilot/add-cat-cpuinfo-to-bencher branch April 27, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants