Skip to content

Install dependencies before trying to get machine info#7857

Merged
eddyashton merged 1 commit intomicrosoft:mainfrom
eddyashton:deps_first
Apr 30, 2026
Merged

Install dependencies before trying to get machine info#7857
eddyashton merged 1 commit intomicrosoft:mainfrom
eddyashton:deps_first

Conversation

@eddyashton
Copy link
Copy Markdown
Member

#7851 just merged, but breaks the Bencher job: https://github.com/microsoft/CCF/actions/runs/25160593167/job/73753717210

++ awk '/^cpu family/{f=$NF} /^model\t/{m=$NF} /^stepping/{s=$NF; printf "%02x%02x%02x",f,m,s; exit}' /proc/cpuinfo
/__w/_temp/4be445c7-1a83-486c-9489-13c415051904.sh: line 6: awk: command not found
...
Error: Process completed with exit code 127.

If we install dependencies first, we should get awk from build-essential.

@eddyashton eddyashton requested a review from a team as a code owner April 30, 2026 11:05
Copilot AI review requested due to automatic review settings April 30, 2026 11:05
@eddyashton eddyashton enabled auto-merge (squash) April 30, 2026 11:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Bencher GitHub Actions workflow failure introduced by #7851 by ensuring required tooling (eg awk) is installed before collecting machine metadata used to derive the Bencher testbed slug.

Changes:

  • Move the ./scripts/setup-ci.sh dependency installation step to run before the shared “Machine info” step in bencher.yml.

@eddyashton eddyashton merged commit 9efd34d into microsoft:main Apr 30, 2026
23 checks passed
cjen1-msft pushed a commit to cjen1-msft/CCF that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants