Skip to content

Update Copilot formatting guidance with CI checks and CMake auto-fix steps#7885

Open
Copilot wants to merge 11 commits into
mainfrom
copilot/sub-pr-7884
Open

Update Copilot formatting guidance with CI checks and CMake auto-fix steps#7885
Copilot wants to merge 11 commits into
mainfrom
copilot/sub-pr-7884

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 14, 2026

This change is a standalone formatting-guide update.

It adds explicit repository guidance for Copilot-driven changes to ensure formatting issues are caught and fixed consistently before push.

  • Formatting/CI guidance update

    • Added instruction to run ./scripts/ci-checks.sh before pushing.
    • Added explicit remediation for CMake formatting failures: run ./scripts/cmake-format-checks.sh -f, then re-run ./scripts/ci-checks.sh before committing.
  • Scope

    • Documentation/instructions only (.github/copilot-instructions.md).
    • No production, test, or source code behavior changes.
# Expected CMake-format remediation flow
./scripts/ci-checks.sh
./scripts/cmake-format-checks.sh -f
./scripts/ci-checks.sh

Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/fb2c3354-e196-424f-8e7a-9d52825c3668

Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
@maxtropets
Copy link
Copy Markdown
Collaborator

@copilot where are the changes?

@maxtropets maxtropets changed the title [WIP] [WIP] Remove stale cchost mentions across tests, samples, schema, and host config Remove stale cchost mentions across tests, samples, schema, and host config May 14, 2026
Copilot AI changed the title Remove stale cchost mentions across tests, samples, schema, and host config Clarify standalone merge target (main) for stale cchost cleanup PR May 14, 2026
Copilot AI requested a review from maxtropets May 14, 2026 13:05
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 14, 2026

@copilot where are the changes?

You’re right — there were no file changes before. I’ve now pushed 32fb0c5, which adds an explicit repo Copilot instruction to always run ./scripts/ci-checks.sh before pushing and to run ./scripts/cmake-format-checks.sh -f when CI reports a CMake format failure (no UI changes to screenshot).

@maxtropets maxtropets marked this pull request as ready for review May 14, 2026 13:22
@maxtropets maxtropets requested a review from a team as a code owner May 14, 2026 13:22
@maxtropets
Copy link
Copy Markdown
Collaborator

@copilot adjust PR description, don't mention ant other PR, it's just a standalone task for the formatting guide.

@maxtropets maxtropets changed the title Clarify standalone merge target (main) for stale cchost cleanup PR Ask copilot to format as per CI requirements in PRs May 14, 2026
@maxtropets maxtropets changed the base branch from copilot/sub-pr-7883 to main May 14, 2026 13:24
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 14, 2026

@copilot adjust PR description, don't mention ant other PR, it's just a standalone task for the formatting guide.

Updated the PR description to keep it strictly as a standalone formatting-guide task and removed references to other PRs. No code changes were needed for this update (HEAD: c191052; no UI changes).

Copilot AI changed the title Ask copilot to format as per CI requirements in PRs Update Copilot formatting guidance with CI checks and CMake auto-fix steps May 14, 2026
## Code changes

- `ci-checks.sh` must run successfully before any commit is pushed.
- Always run `./scripts/ci-checks.sh` in the same way as CI before pushing. If it reports `CMake format` failures, run `./scripts/cmake-format-checks.sh -f` and re-run `./scripts/ci-checks.sh` before committing.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a whole skill for this here: https://github.com/microsoft/CCF/blob/main/.github/skills/formatting-and-linting.md, and we have a pointer to it here: https://github.com/microsoft/CCF/blob/main/.github/copilot-instructions.md#linting-and-formatting - surely we should at most point to this section, not repeat the content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants