Skip to content

Update npm workflow permissions and environment#7892

Merged
achamayou merged 7 commits into
mainfrom
achamayou-patch-2
May 15, 2026
Merged

Update npm workflow permissions and environment#7892
achamayou merged 7 commits into
mainfrom
achamayou-patch-2

Conversation

@achamayou
Copy link
Copy Markdown
Member

@achamayou achamayou commented May 15, 2026

Use an environment, same as we do for pypi in #7879

Copilot AI review requested due to automatic review settings May 15, 2026 13:45
@achamayou achamayou requested a review from a team as a code owner May 15, 2026 13:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the NPM publish GitHub Actions workflow to align with the repository’s newer workflow pattern by using an explicit deployment environment and revised permissions configuration.

Changes:

  • Switch workflow-level token permissions to read-all.
  • Add a job-level environment: npm.
  • Add a job-level permission granting id-token: write (for OIDC-based publishing).

Custom instructions used:

  • .github/copilot-instructions.md
  • .github/instructions/reviewing.instructions.md
  • .github/instructions/changelog.instructions.md

Comment thread .github/workflows/npm.yml
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@achamayou achamayou enabled auto-merge (squash) May 15, 2026 14:02
@achamayou
Copy link
Copy Markdown
Member Author

@copilot use the formatting skill

Copy link
Copy Markdown
Contributor

Copilot AI commented May 15, 2026

@copilot use the formatting skill

I invoked the formatting skill as requested, but it is not available in this agent environment. I then ran a Prettier check directly on .github/workflows/npm.yml, and it is already correctly formatted (no diff). Commit: d77e14a. Screenshot: N/A (no UI changes).

@achamayou
Copy link
Copy Markdown
Member Author

@copilot format the python code using ci-checks.sh -f

Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/08b65845-5377-40dc-b07a-a74a15958f62

Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 15, 2026

@copilot format the python code using ci-checks.sh -f

Done in 6f1a337: I ran scripts/ci-checks.sh -f, installed uv in the runner environment so the Python checks could execute, and committed the resulting Python formatting changes. Screenshot: N/A (no UI changes).

@achamayou achamayou merged commit 8d4b016 into main May 15, 2026
19 checks passed
@achamayou achamayou deleted the achamayou-patch-2 branch May 15, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants