Fix clang-tidy CI break by restoring 2-arg Ledger constructor compatibility#7918
Draft
Copilot wants to merge 3 commits into
Draft
Fix clang-tidy CI break by restoring 2-arg Ledger constructor compatibility#7918Copilot wants to merge 3 commits into
Ledger constructor compatibility#7918Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Build with clang-tidy
Fix clang-tidy CI break by restoring 2-arg Jun 3, 2026
Ledger constructor compatibility
Member
|
@copilot fix the formatting on the one file you changed. |
Contributor
Author
Addressed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build with clang-tidyfailed on release/6.x backport code becausesrc/host/test/ledger.cppcontains call sites ofLedger(ledger_dir, wf), while only the chunk-threshold constructor shape was available there. This PR restores source compatibility without changing existing explicit-threshold behavior.API compatibility shim in
LedgerLedger(const fs::path&, ringbuffer::AbstractWriterFactory&)max_chunk_threshold_size, preserving current semantics while unblocking legacy/backport call sites.Scope
src/host/ledger.h.chunk_threshold.