Skip to content

Split keypair.h#828

Merged
jumaffre merged 2 commits intomicrosoft:masterfrom
jumaffre:split_keypair
Feb 11, 2020
Merged

Split keypair.h#828
jumaffre merged 2 commits intomicrosoft:masterfrom
jumaffre:split_keypair

Conversation

@jumaffre
Copy link
Contributor

Resolves #785

keypair.h is now split into keypair.h, curve.h, verifier.h and hash.h (all under tls/).

@jumaffre jumaffre requested a review from a team as a code owner February 11, 2020 16:40
@ghost
Copy link

ghost commented Feb 11, 2020

split_keypair@4816 aka 20200211.31 vs master ewma over 30 builds from 4447 to 4808
images

@codecov-io
Copy link

Codecov Report

Merging #828 into master will increase coverage by 0.68%.
The diff coverage is 87.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #828      +/-   ##
==========================================
+ Coverage   74.66%   75.35%   +0.68%     
==========================================
  Files         128      154      +26     
  Lines       10404    11520    +1116     
==========================================
+ Hits         7768     8680     +912     
- Misses       2636     2840     +204
Flag Coverage Δ
#e2e_BFT 52.05% <61.47%> (?)
#e2e_CFT 72.06% <67.89%> (+8.35%) ⬆️
#unit_BFT 53.84% <69.72%> (ø) ⬆️
#unit_CFT ?
Impacted Files Coverage Δ
src/node/rpc/frontend.h 66.78% <ø> (-2.45%) ⬇️
src/node/genesisgen.h 88.89% <ø> (+30.56%) ⬆️
src/tls/keypair.h 76.95% <ø> (-0.48%) ⬇️
src/node/history.h 57.02% <ø> (+18.3%) ⬆️
src/enclave/httpsig.h 72.73% <ø> (ø) ⬆️
src/tls/hash.h 100% <100%> (ø)
src/tls/curve.h 76.32% <76.32%> (ø)
src/tls/verifier.h 90.91% <90.91%> (ø)
src/node/rpc/nodeinterface.h 0% <0%> (-100%) ⬇️
src/node/clientsignatures.h 0% <0%> (-54.17%) ⬇️
... and 73 more

@jumaffre jumaffre merged commit 22f36b3 into microsoft:master Feb 11, 2020
eddyashton pushed a commit to eddyashton/CCF that referenced this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split out hashing functionality from keypair.h

4 participants