Release Fixes 2#603
Merged
Merged
Conversation
Member
Author
wiktork
reviewed
Jul 22, 2026
wiktork
reviewed
Jul 22, 2026
| - output: nuget | ||
| displayName: Push to DevDiv InstrumentationEngine feed | ||
| # Dry run: skip the actual push (nothing is published) while the rest of the job | ||
| # -- artifact download above and the promote logic downstream -- still runs. |
Member
There was a problem hiding this comment.
Promote logic doesn't have any dryrun checks. So you can do a dry-run with no push followed by a promote?
Member
Author
There was a problem hiding this comment.
Changed to skip promote when DryRun is set
wiktork
reviewed
Jul 23, 2026
| - deployment: Promote | ||
| displayName: Promote package to Release View | ||
| dependsOn: Publish | ||
| condition: and(eq(variables['PromoteToRelease'], 'True'), ne(variables['DryRun'], 'True')) |
Member
There was a problem hiding this comment.
Does any of this run then with DryRun == true? You have a condition on the overall deployment and on the promote task.
wiktork
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add more fixes to the release pipeline and add a new DryRun variable for testing.