Fix display on Extended Protection in Health Checker#1408
Merged
Conversation
lusassl-msft
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Health Checker isn't converting the
applicationHost.configto anxmltype causingGet-ExtendedProtectionConfigurationto fail out.Issue wasn't caught by pester because when
Get-ApplicationHostConfigwas converted to pull bring back astring[]object type, was because the data in pester wasn't also changed fromImport-ClixmltoGet-Content. Therefore, the pester testing didn't have an issue and was never caught in lab testing.Reason:
This needs to be displayed.
Updated pester testing to handle this correctly.
Fix:
Set the parameter variable to be an
xmltype in thetrycatchblock prior to splat.Resolved #1407
Validation:
Lab tested
Pester tested