Added show detailed explanation parameter - #2294
Merged
Merged
Conversation
Member
|
/azp run |
1 similar comment
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
iserrano76
reviewed
Mar 10, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
When doing multiple changes, even when small, each relatable change should be their own commit at the very least. If the pull request is a lot of random changes, then that should even be broken out into multiple PRs to make things easier to review and easier to understand when trying to figure out why things were changed in the past. |
dpaulson45
requested changes
Mar 12, 2025
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dpaulson45
self-requested a review
March 12, 2025 16:44
dpaulson45
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Added show detailed explanation parameter.
Added functionality to check for illogical inclusions or exclusions for Outbound spam policy, which was missing.
Corrected policy lookup based on rule name to look up policy based on the policy property in the rule.
Reason:
Detailed explanation switch helps users understand output.
Fixed missing functionality and made lookup more robust.
Fix:
Added verification and show more details.
Fixed above issues.
Validation:
Tested in lab.