Make LoadBalancing feature language-independent #875
Merged
Conversation
For some reason in my lab i have a double slash like this: \\adt-e2k13aio1\\logicaldisk(harddiskvolume1)\avg. disk sec/read
Removed lot of code that isn't needed. Also added in the Localized Counter Feature.
lusassl-msft
approved these changes
Jan 31, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
The LoadBalancing report feature does not work on non-English OS.
Performance counters are language dependent. Created a
PerformanceCountersFunctions.ps1file that contains all the functions that we use to translate English counters to the localized counter name on the system that we are querying.Resolve #581
Replaced the PR #797
Reason:
We query the performance counter id and then mapping the id to the localized counter name which we finally use to run the
Get-CountercmdletValidation:
Verified logic worked on both non-English and English lab.