SimplePerf updates#905
Conversation
bill-long
commented
Feb 19, 2022
- Breaking change: -IncludeThread switch is gone. Instead, pass -IncludeCounters "\Thread".
- Now supports two scenarios, Exchange and None. Easy to add more.
- Now supports -IncludeCounters and -ExcludeCounters to customize counter sets.
- Now supports naming collectors, so you can run more than one SimplePerf at a time. This feature is currently not in the docs because I ran out of time.
- Exchange scenario is slimmed down and should result in less data collected than before - closer to the ExPerfWiz defaults.
Method 3 wins. See previous commit. Results: Method 1: 14405 Filter result: 6570 Method 2: 10508 Filter result: 6554 Method 3: 847 Filter result: 6554
There was a problem hiding this comment.
Change looks good and seems to work (validated in lab). However, the default exclude/include doesn't work properly on systems which are using a language other than en-US. We've developed the PerformanceCountersFunctions.ps1 helper function which we use in HealthChecker to address this kind of problem. It might be a good idea to use this helper here as well.
See #875
The filters should still work if you provide the language specific counters for that system. |
|
The latest commit translates the counter names. Note that this means you must always enter counter names in English, even if your current language is not English: However, one problem I haven't figured out how to fix: The script tries to determine if a collector is already running, etc, but those status names are also localized. Need to figure out a language-agnostic way of determining if a collector is running. |
|
Can confirm that it works as expected on German OS. [...] Note that this means you must always enter counter names in English, even if your current language is not English |




