Skip to content

SimplePerf updates#905

Merged
bill-long merged 23 commits into
mainfrom
bilong-simpleperf
Feb 22, 2022
Merged

SimplePerf updates#905
bill-long merged 23 commits into
mainfrom
bilong-simpleperf

Conversation

@bill-long
Copy link
Copy Markdown
Member

  • Breaking change: -IncludeThread switch is gone. Instead, pass -IncludeCounters "\Thread".
  • Now supports two scenarios, Exchange and None. Easy to add more.
  • Now supports -IncludeCounters and -ExcludeCounters to customize counter sets.
  • Now supports naming collectors, so you can run more than one SimplePerf at a time. This feature is currently not in the docs because I ran out of time.
  • Exchange scenario is slimmed down and should result in less data collected than before - closer to the ExPerfWiz defaults.

Copy link
Copy Markdown
Contributor

@lusassl-msft lusassl-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good and seems to work (validated in lab). However, the default exclude/include doesn't work properly on systems which are using a language other than en-US. We've developed the PerformanceCountersFunctions.ps1 helper function which we use in HealthChecker to address this kind of problem. It might be a good idea to use this helper here as well.

image

See #875

@dpaulson45
Copy link
Copy Markdown
Member

Change looks good and seems to work (validated in lab). However, the default exclude/include doesn't work properly on systems which are using a language other than en-US. We've developed the PerformanceCountersFunctions.ps1 helper function which we use in HealthChecker to address this kind of problem. It might be a good idea to use this helper here as well.

image

See #875

The filters should still work if you provide the language specific counters for that system.

@lusassl-msft
Copy link
Copy Markdown
Contributor

lusassl-msft commented Feb 21, 2022

Correct, the filters are working correctly if you pass the language specific counter name. The default exclude/include counters are hardcoded and so don't work on non en-US systems.

image

@bill-long
Copy link
Copy Markdown
Member Author

The latest commit translates the counter names. Note that this means you must always enter counter names in English, even if your current language is not English:

image

However, one problem I haven't figured out how to fix:

image

The script tries to determine if a collector is already running, etc, but those status names are also localized. Need to figure out a language-agnostic way of determining if a collector is running.

@bill-long
Copy link
Copy Markdown
Member Author

Got it:

image

@lusassl-msft
Copy link
Copy Markdown
Contributor

Can confirm that it works as expected on German OS.
We should document this in the docs:

[...] Note that this means you must always enter counter names in English, even if your current language is not English

lusassl-msft
lusassl-msft previously approved these changes Feb 22, 2022
Comment thread Performance/SimplePerf/SimplePerf.ps1
@dpaulson45 dpaulson45 self-requested a review February 22, 2022 14:35
Comment thread Performance/SimplePerf/SimplePerf.ps1 Outdated
@bill-long bill-long merged commit 52af866 into main Feb 22, 2022
@bill-long bill-long deleted the bilong-simpleperf branch February 22, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants