fix: Enhance container image build and push instructions and hooks - #329
Merged
Conversation
KanchanN-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
nchandhi,
sethsteenken and
toherman-msft
as code owners
July 22, 2026 10:06
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the azd hook messaging in azure.yaml to provide clearer guidance after provisioning/deployment, including explicit instructions to manually build and push container images and links for support when deployments fail.
Changes:
- Added/updated
preprovisionmessaging to direct users to open an issue with deployment logs if provisioning/deployment fails. - Enhanced
postdeploymessaging for POSIX and Windows to show clearer next steps for building/pushing images and to surface app details.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
azure.yaml:16
hooks.preprovisiondefinesposixtwice (this new block and an existingposixblock later). YAML duplicate keys typically result in the first block being ignored/overridden (or a parse error, depending on parser), so these new instructions likely won’t run. Keep only oneposixentry and merge content if needed.
posix:
run: |
echo ""
echo " ---------------------------------------------------------------------------------------------------"
echo " Note: If deployment fails or you encounter an issue, please open an issue with the deployment logs."
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
azure.yaml:65
- The PR description refers to a
postprovisionhook and instructions shown after provisioning, but this file updates thepostdeployhook (and the messaging says "Deployment Complete"). That mismatch can confuse maintainers/users about when these instructions run (provision vs deploy). Align either the PR description or the hook name/wording so they describe the same lifecycle event.
Write-Host "`n========================================" -ForegroundColor Green
Write-Host " Deployment Complete " -ForegroundColor Green
Write-Host "========================================`n" -ForegroundColor Green
Write-Host "Next step: build and push container images to the dedicated ACR (remote build):" -ForegroundColor Yellow
Write-Host " ./scripts/acr_build_push.ps1" -ForegroundColor Cyan
Roopan-Microsoft
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the deployment completion messages in the
azure.yamlworkflow to provide clearer instructions and improved formatting for both Linux (sh) and Windows (pwsh) environments.Improvements to deployment messaging:
./scripts/acr_build_push.sh../scripts/acr_build_push.ps1, and better formatting for readability.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information