Skip to content

fix: Enhance container image build and push instructions and hooks - #329

Merged
Roopan-Microsoft merged 6 commits into
devfrom
manual-image-buidpush
Jul 22, 2026
Merged

fix: Enhance container image build and push instructions and hooks#329
Roopan-Microsoft merged 6 commits into
devfrom
manual-image-buidpush

Conversation

@KanchanN-Microsoft

@KanchanN-Microsoft KanchanN-Microsoft commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Purpose

This pull request updates the deployment completion messages in the azure.yaml workflow to provide clearer instructions and improved formatting for both Linux (sh) and Windows (pwsh) environments.

Improvements to deployment messaging:

  • Enhanced the post-deployment output for the Linux shell by adding clear section headers, a "Deployment Complete" banner, and explicit next-step instructions to build and push container images using ./scripts/acr_build_push.sh.
  • Improved the Windows shell output with colored banners, clearer instructions for building and pushing container images using ./scripts/acr_build_push.ps1, and better formatting for readability.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@KanchanN-Microsoft

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the azd hook messaging in azure.yaml to provide clearer guidance after provisioning/deployment, including explicit instructions to manually build and push container images and links for support when deployments fail.

Changes:

  • Added/updated preprovision messaging to direct users to open an issue with deployment logs if provisioning/deployment fails.
  • Enhanced postdeploy messaging for POSIX and Windows to show clearer next steps for building/pushing images and to surface app details.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread azure.yaml Outdated
Comment thread azure.yaml Outdated
Comment thread azure.yaml
Copilot AI review requested due to automatic review settings July 22, 2026 10:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

azure.yaml:16

  • hooks.preprovision defines posix twice (this new block and an existing posix block later). YAML duplicate keys typically result in the first block being ignored/overridden (or a parse error, depending on parser), so these new instructions likely won’t run. Keep only one posix entry and merge content if needed.
    posix:
      run: |
        echo ""
        echo "  ---------------------------------------------------------------------------------------------------"
        echo "  Note: If deployment fails or you encounter an issue, please open an issue with the deployment logs."

Copilot AI review requested due to automatic review settings July 22, 2026 10:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

azure.yaml:65

  • The PR description refers to a postprovision hook and instructions shown after provisioning, but this file updates the postdeploy hook (and the messaging says "Deployment Complete"). That mismatch can confuse maintainers/users about when these instructions run (provision vs deploy). Align either the PR description or the hook name/wording so they describe the same lifecycle event.
        Write-Host "`n========================================" -ForegroundColor Green
        Write-Host "      Deployment Complete      " -ForegroundColor Green
        Write-Host "========================================`n" -ForegroundColor Green

        Write-Host "Next step: build and push container images to the dedicated ACR (remote build):" -ForegroundColor Yellow
        Write-Host "     ./scripts/acr_build_push.ps1" -ForegroundColor Cyan

Comment thread azure.yaml Outdated
Copilot AI review requested due to automatic review settings July 22, 2026 10:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread azure.yaml
@Roopan-Microsoft
Roopan-Microsoft merged commit b85893e into dev Jul 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants