Fix PreserveSig COM source generation - #1746
Merged
Jevan Saks (jevansaks) merged 1 commit intoJul 28, 2026
Merged
Conversation
Handle retained RetVal parameters in unmanaged wrappers and avoid the COM source generator's retVal identifier collision. Add focused and full-generation regression coverage for #1745. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7315c941-053c-41b5-9e78-92703d49ce71
Jevan Saks (jevansaks)
marked this pull request as ready for review
July 28, 2026 00:42
Manodasan Wignarajah (manodasanW)
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[RetVal]parameters in unmanaged COM wrappers so vtable calls receive pointers__retVal_nativecollision by renaming by-refretValparameters on preserved HRESULT interfacesnet10.0PreserveSig full-generation test and dedicated CI shardValidation
dotnet build -t:build,pack -c Release -warnAsError -warnNotAsError:NU1901,NU1902,NU1903,NU1904FullGeneration_Net10_PreserveSigFixes #1745