Update MessagePack to 2.5.301 (CVE-2026-48109, CVE-2026-48506) - #1779
Merged
Jevan Saks (jevansaks) merged 1 commit intoAug 7, 2026
Merged
Conversation
Vineeth Thomas Alex (vineeththomasalex)
marked this pull request as ready for review
August 7, 2026 22:27
Jevan Saks (jevansaks)
approved these changes
Aug 7, 2026
Jevan Saks (jevansaks)
deleted the
vithoma/s360-messagepack-cve-2026-48109-48506
branch
August 7, 2026 23:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change being made?
S360 flagged two high-severity Component Governance alerts against
MessagePack 2.2.85in this repo (/Directory.Packages.props, branchmain):Lz4Block/Lz4BlockArray) →AccessViolationException/ possible memory disclosureMessagePackReader.TrySkip()bypassesMaximumObjectGraphDepth→ unbounded recursion /StackOverflowExceptionBoth are fixed in 2.5.301 (v2 line).
Tracked by AB#63114275 and AB#63114279.
The
<PackageVersion>carried a comment saying we must match the MessagePack version used by win32metadata (#371). That comment is now stale in the opposite direction: win32metadata'sScrapeDocsandMicrosoft.Windows.SDK.Win32Docs— the producers ofapidocs.msgpackthatDocs.csreads — already reference MessagePack 2.5.187. Moving to 2.5.301 brings us back into alignment rather than out of it. (Renovate is configured to skip MessagePack updates in.github/renovate.json, which is why this drifted.)What changed?
Directory.Packages.props:MessagePack2.2.85→2.5.301. Single-line change; the explanatory comment is left in place.No source changes were needed.
Docs.csonly deserializes, via a hand-writtenIMessagePackFormatter<ApiDetails>on top ofStandardResolver(deliberately avoidingDynamicObjectResolver). Every API it uses —MessagePackSerializerOptions.Standard.WithResolver,CompositeResolver.Create,MessagePackReader.ReadArrayHeader/ReadString/Skip,IFormatterResolver.GetFormatterWithVerify<T>— is unchanged in 2.5.x, and the msgpack wire format is stable across the 2.x line.MessagePackAnalyzerwas already on2.5.192, so the library and analyzer are now on matching majors/minors.How was the change tested?
Packaging path reviewed for regressions:
Microsoft.Windows.CsWin32.nuspecandMicrosoft.Windows.CsWin32.targetscopyMessagePack.dllandMessagePack.Annotations.dllintoanalyzers\dotnet\roslyn5.0\cs\by filename (no version-pinned paths), and 2.5.301 still ships exactly those two assemblies with anetstandard2.0target — so the analyzer package layout and theAuthenticode="3PartySHA2"signing conditions are unaffected.Locally, on Windows with the .NET 10.0.302 SDK:
Confirmed the flowed assemblies:
And exercised the actual deserialization of the shipped
apidocs.msgpack(the only real compatibility risk):No pipelines were queued; CI on this PR will provide full coverage.
For more information on the code review process, see the Code Review Guidelines & Etiquette.