Preserve coclass generic type fields for AOT - #1810
Merged
Merged
Conversation
Enable AOT analysis in build-task tests and verify generated coclass helpers propagate the COM output type annotation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 269885ab-a187-403f-81ef-4421f979d78f
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 269885ab-a187-403f-81ef-4421f979d78f
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 269885ab-a187-403f-81ef-4421f979d78f
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 269885ab-a187-403f-81ef-4421f979d78f
Jevan Saks (jevansaks)
marked this pull request as ready for review
September 2, 2026 21:31
Jevan Saks (jevansaks)
enabled auto-merge (squash)
September 2, 2026 21:52
Sergio Pedri (Sergio0694)
approved these changes
Sep 2, 2026
Jevan Saks (jevansaks)
deleted the
user/jevansa/coclass-aot-annotation
branch
September 2, 2026 23:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DynamicallyAccessedMembers(PublicFields)to generated coclassCreateInstance<T>helpers when automatic WinRT output marshalling is active.IL2091to an error.This fixes Native AOT analysis failures in consumers that call generated helpers such as
ShellLink.CreateInstance<T>().Testing
Microsoft.Windows.CsWin32.Tests: 827 passedGenerationSandbox.BuildTask.Tests: 8 passed on net9 and 8 passed on net10build,packwith warnings as errors: succeeded with 0 warnings