Remove leftover artifacts from the C++ cswinrt migration#2479
Merged
Sergio0694 merged 2 commits intoJul 2, 2026
Conversation
The native cswinrt.exe projection generator was ported to C# and src/cswinrt/cswinrt.vcxproj was deleted (#2440), but three authoring test projects still had stale ProjectReference entries pointing at it. Remove them from AuthoringTest2, AuthoringTest3, and AuthoringConsumptionTest2.AOT. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
manodasanW
approved these changes
Jul 1, 2026
The CsWinMD tool and its CSWinMDComponent test were removed in #2408, but the projection generator port (#2440) accidentally re-added the orphaned CSWinMDComponent.vcxproj.filters file. It is the only remaining file in the directory, is not part of any solution, and is referenced by nothing. Remove it (and the now-empty directory). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sergio0694
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove dead build artifacts left behind by the migration of the native C++
cswinrt.exeprojection generator to C#: three staleProjectReferenceentries pointing at the deletedcswinrt.vcxproj, and an orphanedCSWinMDComponent.vcxproj.filtersfile.Motivation
Two separate cleanups from the same C++ → C# migration effort:
1. Stale
cswinrt.vcxprojproject references. The native C++ projection generator (src/cswinrt/cswinrt.vcxproj, producingcswinrt.exe) was ported to C# and deleted in #2440. A few authoring test projects still referenced that.vcxprojpurely as a build-ordering/tool dependency, so the references were left dangling.These didn't break the build because a
ProjectReferenceto a missing project file is not fatal by default. MSBuild's_SplitProjectReferencesByFileExistencetarget sorts references into_MSBuildProjectReferenceExistentand_MSBuildProjectReferenceNonexistentbased on whether the file exists on disk. For the nonexistent bucket,ResolveProjectReferencesemits MSB9008 (The referenced project '...' does not exist.) and simply skips it, because the severity is downgraded to a warning unlessErrorOnMissingProjectReferenceis set toTrue(it isn't set anywhere in this repo). Since the reference was only a native build-ordering dependency and produced no assembly these projects consume, dropping it changes nothing beyond silencing the MSB9008 warning.2. Orphaned
CSWinMDComponent.vcxproj.filters. The legacy CsWinMD authoring tool and itsCSWinMDComponenttest were removed in #2408, which deleted the entiresrc/Tests/CSWinMDComponentdirectory. The projection generator port (#2440) then accidentally re-added just theCSWinMDComponent.vcxproj.filtersfile. It was the only remaining file in that directory, is not part of any solution, and is referenced by nothing.Changes
src/Tests/AuthoringTest2/AuthoringTest2.csproj: remove the stalecswinrt.vcxprojproject referencesrc/Tests/AuthoringTest3/AuthoringTest3.csproj: remove the stalecswinrt.vcxprojproject referencesrc/Tests/AuthoringConsumptionTest2.AOT/AuthoringConsumptionTest2.AOT.csproj: remove the stalecswinrt.vcxprojproject referencesrc/Tests/CSWinMDComponent/CSWinMDComponent.vcxproj.filters: remove the orphaned filters file (and the now-empty directory)