Fix exception marshalling for generated COM interfaces - #2549
Merged
Sergio Pedri (Sergio0694) merged 1 commit intoSep 7, 2026
Merged
Conversation
Register UnmanagedToManagedOut for RestrictedErrorInfoExceptionMarshaller and cover both generated COM directions with success and failure cases. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Sergio Pedri (Sergio0694)
requested a review
from Manodasan Wignarajah (manodasanW)
September 7, 2026 12:26
Sergio Pedri (Sergio0694)
enabled auto-merge (squash)
September 7, 2026 12:31
Manodasan Wignarajah (manodasanW)
approved these changes
Sep 7, 2026
Sergio Pedri (Sergio0694)
deleted the
user/sergiopedri/exception-marshalling
branch
September 7, 2026 16:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the missing
UnmanagedToManagedOutannotation toRestrictedErrorInfoExceptionMarshallerso[GeneratedComInterface]can use it to marshal managed exceptions back to native callers.Motivation
The marshaller only registered
ManagedToUnmanagedOut, so configuring it asExceptionToUnmanagedMarshallercaused the .NET COM source generator to reportSYSLIB1051. Existing exception tests did not exercise this marshaller through generated COM interfaces, leaving this configuration unsupported without regression coverage.Changes
src\WinRT.Runtime2\InteropServices\Marshalling\RestrictedErrorInfoExceptionMarshaller.cs: registerUnmanagedToManagedOutalongside the existingManagedToUnmanagedOutmode.src\Tests\UnitTest\ComGenerationTests.cs: add generated COM interfaces and a managed implementation to cover both directions, including successful calls, HRESULT conversion, and preservation of the original exception. Force a unique RCW for the return-value case so the test crosses the generated COM boundary rather than unwrapping the managed object, and release COM references and thread error state after each case.